Fix new warnings causing CI build failures on rustc beta #2954
Conversation
TheBlueMatt
force-pushed
the
2024-03-test-ci-beta-fail
branch
from
4f5ae10 to
9fac656
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2954 +/- ##
==========================================
- Coverage 89.38% 89.35% -0.03%
==========================================
Files 117 117
Lines 95623 95597 -26
Branches 95623 95597 -26
==========================================
- Hits 85476 85425 -51
- Misses 7918 7935 +17
- Partials 2229 2237 +8 ☔ View full report in Codecov by Sentry. |
|
Will try to fix the new regression in our lockorder testing on Windows rustc beta as well. |
|
Unfortunately still failing, it seems. :( |
|
Sorry, was just adding logging so I could see what was up. Sadly it looks like a backtrace or rustc regression, so we'll have to ignore it for now. Opened rust-lang/rust#122857 upstream |
TheBlueMatt
force-pushed
the
2024-03-test-ci-beta-fail
branch
5 times, most recently
from
7381a1d to
88314d6
Compare
|
Also fixed all the new non-failing warnings....turns out there were a lot. |
TheBlueMatt
force-pushed
the
2024-03-test-ci-beta-fail
branch
from
88314d6 to
2be2214
Compare
|
Yea, apparently rustc may do a point release to fix backtraces on Windows (not actually sure why we aren't failing on stable and only failing on beta, but whatever). |
New rustc now warns on duplicate imports when one of the imports is from a wildcard import or the default prelude. Thus, because we often don't actually use the imports from our prelude (as they exist to duplicate the `std` default prelude), we have to mark most of our `crate::prelude` imports with `#[allow(unused_imports)]`, which we do here.
New rustc beta now warns on duplicate imports when one of the imports is from a wildcard import or the default prelude. Thus, for simplicity, we need to make our `crate::prelude` mostly identical to the `std` one, allowing us to always simply use the `crate::prelude` and let it decide if we need to import anything.
New rustc beta now warns on duplicate imports when one of the imports is from a wildcard import or the default prelude. Thus, to avoid this here we prefer to always use `crate::prelude::*` and let it decide if we actually need to import anything.
We no longer use `Time` during scoring, which makes several of its methods now useless. We remove those here.
... that newer rustc now warns about.
|
Rebased. |
TheBlueMatt
force-pushed
the
2024-03-test-ci-beta-fail
branch
from
2be2214 to
2f734f9
Compare
|
Given that these are ~trivial changes, will merge after CI passes. |
No description provided.