Send back the actual received amount, not expected on HTLC fails #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2019-01-back-fail-privacy
branch
5 times, most recently
from
29cffba to
571f03e
Compare
Best reviewed with -b
This shouldn't be required, but it may help prevent some downstream race conditions due to clients not sending message events quickly enough and trying to send stale messages before new channel_reestablish messages.
This is an oversight as the MessageSendEvent is otherwise entirely useless.
Sadly this requires reducing the honggfuzz iterations to fit within Travis' runtime limits.
TheBlueMatt
force-pushed
the
2019-01-back-fail-privacy
branch
from
571f03e to
8b63892
Compare
dongcarl
reviewed
Jan 24, 2019
src/ln/channelmanager.rs
Outdated
| @@ -1357,17 +1359,17 @@ impl ChannelManager { | |||
| /// after a PaymentReceived event. | |||
| /// expected_value is the value you expected the payment to be for (not the amount it actually | |||
There was a problem hiding this comment.
- The comment for
expected_valueis no longer needed - The comment should describe what the function does instead of under what conditions it will be called
- The comment should describe what the return value represents
This resolves an incorrect implementation of the spec and fixes a major privacy leak. Fixes GH lightningdevkit#289.
TheBlueMatt
force-pushed
the
2019-01-back-fail-privacy
branch
from
8b63892 to
74588b2
Compare
|
Fixed the docs, thanks. We have lots of TODOs in the code, sadly we're not at the production-ready state yet where we get all of them into the issue tracker :/. |
|
ACK 74588b2, a nit, but seems to me commit message isn't strictly right as TODO isn't implemented, just lay work for fix |
|
The TODO refers to HTLCs/payments with the same hash, but different values. |
|
Ah yes good, read too fast, think at first you were aiming to solve both fail/claim cases with this commit. TODO implies to add an expected value parameter to claim_funds function in future commit, may need to update a good chunk of things, so good for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an incorrect implementation of the spec and fixes a
major privacy leak.
Fixes GH #289.