Skip to content

Add missing Offer::expects_quantity to tests #3079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024

Conversation

jkczyz
Copy link
Contributor

@jkczyz jkczyz commented May 22, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.54%. Comparing base (da7a916) to head (7ceb709).
Report is 22 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3079      +/-   ##
==========================================
+ Coverage   89.79%   90.54%   +0.75%     
==========================================
  Files         116      117       +1     
  Lines       96466   100937    +4471     
  Branches    96466   100937    +4471     
==========================================
+ Hits        86619    91393    +4774     
+ Misses       7290     7089     -201     
+ Partials     2557     2455     -102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tnull
Copy link
Contributor

tnull commented May 23, 2024

Seems straightforward increase of test strictness, merging without second reviewer.

@tnull tnull merged commit 1d421d3 into lightningdevkit:main May 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants