Move serialization of channel_state fields to channel_state.rs
#3091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkczyz
previously approved these changes
Jun 4, 2024
|
Strict code movement ( |
TheBlueMatt
force-pushed
the
2024-06-channel_state_ser
branch
from
e8bc408 to
9b5e1b7
Compare
|
Grrr, rustfmt. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3091 +/- ##
==========================================
- Coverage 89.89% 89.85% -0.05%
==========================================
Files 118 119 +1
Lines 97471 98488 +1017
Branches 97471 98488 +1017
==========================================
+ Hits 87624 88498 +874
- Misses 7280 7422 +142
- Partials 2567 2568 +1 ☔ View full report in Codecov by Sentry. |
|
CI still failing... unused imports 😭 |
1f616c0 moved a handful of structs to the new `channel_state.rs` but forgot to move their serialization logic with them, which is corrected here.
TheBlueMatt
force-pushed
the
2024-06-channel_state_ser
branch
from
9b5e1b7 to
64e5dc4
Compare
|
Ugh, fixed. |
jkczyz
approved these changes
Jun 4, 2024
|
Okay, same as above applies, just landing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1f616c0 moved a handful of structs to the new
channel_state.rsbut forgot to move their serialization logic with them, which is corrected here.