Inline ignore_error macro #3093
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes dependency of watched_outputs from per_commitment_claimable_outpoints, it is required since we will no longer have direct access to per_commitment_claimable_outpoints once we start publishing PersistClaimInfo as part of lightningdevkit#3049.
arik-so
previously approved these changes
Jun 4, 2024
TheBlueMatt
dismissed
arik-so’s stale review
The merge-base changed after approval.
TheBlueMatt
reviewed
Jun 4, 2024
| let per_commitment_key = ignore_error!(SecretKey::from_slice(&secret)); | ||
| let per_commitment_key = match SecretKey::from_slice(&secret) { | ||
| Ok(per_commitment_key) => per_commitment_key, | ||
| Err(_) => return (claimable_outpoints, to_counterparty_output_info) |
There was a problem hiding this comment.
Actually, blindly ignoring this is a bit of a holdover from when we thought we could use the same ChannelMonitor as a watchtower. We should definitely be logging here, at a minimum, and maybe panicking.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3093 +/- ##
==========================================
+ Coverage 89.90% 91.16% +1.25%
==========================================
Files 117 119 +2
Lines 97415 106993 +9578
Branches 97415 106993 +9578
==========================================
+ Hits 87581 97535 +9954
+ Misses 7272 7050 -222
+ Partials 2562 2408 -154 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3081