Remove usage of blockdata:: from bitcoin paths

[tcharding]

In rust-bitcoin the blockdata module is a code organisation thing, it should never have been public. One day those guys would like to remove it, so as not to be a PITA for rust-lighting when they do lets remove all usage of blockdata:: now.

Internal change only, no externally visible changes.

[tcharding]

I can't work out what incantation of rustfmt to use to get past CI, can you tell me please. I tried removing --check from ci/rustfmt.sh but got a million unrelated changes?

[tcharding]

As one of the idiots that pushed for rustfmt in rust-bitcoin I'm aware of the irony in my request :)

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.78%. Comparing base (88e1b56) to head (0c19a99).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3146      +/-   ##
==========================================
- Coverage   89.83%   89.78%   -0.05%     
==========================================
  Files         121      121              
  Lines       98900    98900              
  Branches    98900    98900              
==========================================
- Hits        88847    88802      -45     
- Misses       7457     7494      +37     
- Partials     2596     2604       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[TheBlueMatt]

Oh sorry I can't read lol. rustfmt is mad about the ordering of your imports, so you should be able to just reorder imports repeatedly until the CI script passes.

[tcharding]

Sweet, yesterday I thought I'd gone mad but master is broken right now - there are formatting issues on it.

[TheBlueMatt]

I don't believe so? CI on latest git doesn't show any issues on the rustfmt job, the issue here is that removing the blockdata changed the alphabetical order of the imports so rustfmt is mad.

[tcharding]

I'm traveling for the week, I'll come back to this. Thanks

[TheBlueMatt]

Any desire to pick this back up?

[tcharding]

Not if I have to re-order all the import statements by hand, sorry man.

[TheBlueMatt]

You can rustfmt individual files, but alright, up to you 🤷‍♂️

[tcharding]

FWIW I had another go at this and as far as I can tell there are formatting issues on master but reading the workflow I'm confused as to how they got past CI, but you guys have a fair few red PRs right now so I didn't look any further.