Use native check-cfg lint in cargo beta #3173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the newly introduced conditional configuration checks that are now configurable withint Cargo (beta). This allows us to get rid of our custom python script that checks for expected features and cfgs. This does introduce a warning regarding the unknown lint in Cargo versions prior to the current beta, but since these are not rustc errors, they won't break any builds with the "-D warnings" RUSTFLAG. Moving to this lint actually exposed the "strict" feature not being present in the lightning-invoice crate, as our python script didnt correctly parse the cfg_attr where it appeared.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3173 +/- ##
==========================================
- Coverage 89.80% 89.79% -0.02%
==========================================
Files 121 121
Lines 100045 100045
Branches 100045 100045
==========================================
- Hits 89845 89831 -14
- Misses 7533 7537 +4
- Partials 2667 2677 +10 ☔ View full report in Codecov by Sentry. |
tnull
approved these changes
Jul 12, 2024
TheBlueMatt
approved these changes
Jul 15, 2024
| @@ -18,6 +18,7 @@ rustdoc-args = ["--cfg", "docsrs"] | |||
| default = ["std"] | |||
| no-std = ["lightning/no-std"] | |||
| std = ["bitcoin/std", "lightning/std", "bech32/std"] | |||
| strict = [] | |||
There was a problem hiding this comment.
Ha, it caught an issue, cool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the newly introduced conditional configuration checks that are now configurable withint Cargo (beta).
This allows us to get rid of our custom python script that checks for expected features and cfgs.
This does introduce a warning regarding the unknown lint in Cargo versions prior to the current beta, but since these are not rustc errors, they won't break any builds with the "-D warnings" RUSTFLAG.
Moving to this lint actually exposed the "strict" feature not being present in the lightning-invoice crate, as our python script didnt correctly parse the cfg_attr where it appeared.
Fixes #3119