Skip to content

rustfmt: Run on lightning-net-tokio #3189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Jul 18, 2024

.. we continue the rustfmt story with lightning-net-tokio.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 60.08772% with 91 lines in your changes missing coverage. Please review.

Project coverage is 89.74%. Comparing base (0cfe55c) to head (61dd867).

Files Patch % Lines
lightning-net-tokio/src/lib.rs 60.08% 89 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3189      +/-   ##
==========================================
- Coverage   89.76%   89.74%   -0.02%     
==========================================
  Files         121      121              
  Lines      100826   100956     +130     
  Branches   100826   100956     +130     
==========================================
+ Hits        90507    90607     +100     
- Misses       7636     7672      +36     
+ Partials     2683     2677       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tnull tnull force-pushed the 2024-07-rustfmt-lightning-net-tokio branch from 1a2721e to 61dd867 Compare July 18, 2024 08:23
Copy link
Contributor

@arik-so arik-so left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tnull
Copy link
Contributor Author

tnull commented Jul 30, 2024

Landing this

@tnull tnull merged commit 50d21b7 into lightningdevkit:main Jul 30, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants