Set default ChannelHandshakeLimits::min_funding_satoshis to 1000

[dunxen]

The original default value of 0 was inconsistent with the minimum requirement of 1000 satoshis in ChannelHandshakeConfig::their_channel_reserve_proportional_millionths.

Fixes #2058.

[dunxen]

Looking for some other inconsistencies at the moment.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.73%. Comparing base (1d9d911) to head (779b194).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3220      +/-   ##
==========================================
- Coverage   89.74%   89.73%   -0.01%     
==========================================
  Files         122      122              
  Lines      101912   101903       -9     
  Branches   101912   101903       -9     
==========================================
- Hits        91457    91439      -18     
- Misses       7765     7773       +8     
- Partials     2690     2691       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tnull]

Generally looks good, but I wonder if we should set the lower bound dynamically rather than just aligning the default values?

[TheBlueMatt]

Generally looks good, but I wonder if we should set the lower bound dynamically rather than just aligning the default values?

Sadly "minimum channel value" is a really common thing to configure, so removing the option would probably leave the API lacking for our users :(

[TheBlueMatt]

Thanks!

[TheBlueMatt]

Oops, broken link:

error: unresolved link to `ChannelHandShakeConfig::their_channel_reserve_proportional_millionths`
   --> lightning/src/util/config.rs:261:20
    |
261 |     /// (Minimum of [`ChannelHandShakeConfig::their_channel_reserve_proportional_millionths`])
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no item named `ChannelHandShakeConfig` in scope
    |

[dunxen]

Oops, broken link:

Sorry! Fixed and checked locally (this time)