Skip to content

rustfmt: Run on lightning-persister #3222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Aug 2, 2024

We run rustfmt on the lightning-persister crate.

Seems rather straightforward.

@tnull tnull changed the title rustfmt: Run on lightning persister rustfmt: Run on lightning-persister Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 65.02732% with 64 lines in your changes missing coverage. Please review.

Project coverage is 89.68%. Comparing base (43dcf2f) to head (e393893).
Report is 8 commits behind head on main.

Files Patch % Lines
lightning-persister/src/fs_store.rs 52.63% 43 Missing and 2 partials ⚠️
lightning-persister/src/utils.rs 42.42% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3222      +/-   ##
==========================================
- Coverage   89.73%   89.68%   -0.05%     
==========================================
  Files         124      124              
  Lines      102376   102498     +122     
  Branches   102376   102498     +122     
==========================================
+ Hits        91869    91930      +61     
- Misses       7813     7868      +55     
- Partials     2694     2700       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

G8XSU
G8XSU previously approved these changes Aug 6, 2024
@tnull tnull requested a review from TheBlueMatt August 13, 2024 13:22
@tnull tnull force-pushed the 2024-08-rustfmt-lightning-persister branch from c68adef to e393893 Compare August 17, 2024 07:23
@tnull
Copy link
Contributor Author

tnull commented Aug 17, 2024

Rebased on main to resolve conflicts.

@TheBlueMatt TheBlueMatt merged commit bad5e32 into lightningdevkit:main Aug 19, 2024
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants