Add a script to automatically rustfmt all required files
#3226
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3226 +/- ##
==========================================
+ Coverage 89.74% 90.07% +0.32%
==========================================
Files 122 122
Lines 101875 103449 +1574
Branches 101875 103449 +1574
==========================================
+ Hits 91429 93180 +1751
+ Misses 7761 7642 -119
+ Partials 2685 2627 -58 ☔ View full report in Codecov by Sentry. |
As we now require `rustfmt` pass on a subset of our files, its helpful to have a script which will automatically format any required files so that contributors don't need to think too hard about it.
TheBlueMatt
force-pushed
the
2024-08-rustfmt-contrib
branch
from
cb952da to
0079ca8
Compare
|
Note that running the script produces a bunch of changes. |
|
And thanks! |
You mean on latest git? It shouldn't..... |
|
Ah, the sort order is the problem. If you add this it fixes it (need to create the # Sort order is effected by locale. See `man sort`.
# > Set LC_ALL=C to get the traditional sort order that uses native byte values.
export LC_ALL=C |
|
Ah, oops, duh, thanks. |
| #!/bin/bash | ||
| set -eo pipefail | ||
|
|
||
| export LC_ALL=C |
There was a problem hiding this comment.
nit: Could have copied the comment to annotate why we need this. Any case, no real blocker.
|
Thanks for doing this one @TheBlueMatt, I did #3231 using it :) |
|
Thanks for complaining about it - it was an obvious oversight we should have had :) |
|
You welcome! Complaining is my specialty :) |
As we now require
rustfmtpass on a subset of our files, its helpful to have a script which will automatically format any required files so that contributors don't need to think too hard about it.