Update RGS stats for August 2024. #3267
Conversation
|
I think we might wanna remove the processing times considering the amount of variance they might exhibit depending on the environment. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3267 +/- ##
==========================================
+ Coverage 89.82% 90.66% +0.84%
==========================================
Files 125 126 +1
Lines 102830 110644 +7814
Branches 102830 110644 +7814
==========================================
+ Hits 92368 100318 +7950
+ Misses 7752 7740 -12
+ Partials 2710 2586 -124 ☔ View full report in Codecov by Sentry. |
|
Yea, I think lets remove the processing times. Otherwise lgtm. |
|
Understanding the processing time is very important. People want to know whether app startup latency is going to be 0.5 seconds or 5 seconds or 50 seconds. Can we include processing time along with which processor was tested? Or bonus points for a couple of data points so we have a range? |
|
What is the explanation for the data reduction with the new measurement? |
|
In that case perhaps we should publish processing times for three-four different environments, say a mobile phone, an Intel chipset laptop, and an ARM chipset computer? I could also test-run it on a Pi. |
|
Any update here? |
|
Mobile benchmarks were blocked on Swift bindings. I'll be able to run them today. |
|
What were the results @arik-so ? |
|
Eh, sadly more complicated than anticipated to just run a couple benchmarks on mobile. Still pending Apple reinstating my lapsed developer account, without which Xcode won't allow me to run anything on a real mobile device. |
arik-so
force-pushed
the
rgs_metrics_2024-08
branch
from
89d4f40 to
c4dea14
Compare
|
I asked @jurvis to run the benchmarks instead, and updated the values accordingly. These new times are significantly faster than the old times because the previous times were measured on an iPhone 11 Pro. |
|
Cool, should this be un-draft-ed now? |
| @@ -122,23 +122,25 @@ broadcast on the network may be taken into account when calculating the delta. | |||
| ## Performance | |||
|
|
|||
| Given the primary purpose of this utility is a faster graph sync, we thought it might be helpful to | |||
| provide some examples of various delta sets. These examples were calculated as of May 19th 2022 | |||
| provide some examples of various delta sets. These examples were calculated as of August 2024 | |||
There was a problem hiding this comment.
| provide some examples of various delta sets. These examples were calculated as of August 2024 | |
| provide some examples of various delta sets. These examples were calculated as of August 2024 |
arik-so
force-pushed
the
rgs_metrics_2024-08
branch
from
c4dea14 to
2c1e828
Compare
|
Lgtm! |
This updates the RGS metrics to the latest measurements for V2 gossip.