Use more Writeable/Readable for Option<T> in ChannelMonitor serializer/deserializer #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once the HTLCSources' are set to None, Option<Box> will be ptrsize_t (ie 8 bytes on 64-bit platforms) long. However, Option has a constant size, so setting it to None will not free any memory, which sucks cause there are potentially a lot of them (though they're only (currently) about 64 bytes long). |
ariard
force-pushed
the
2019-03-option-serialize-channel-monitor
branch
from
356908b to
bcd7bae
Compare
ariard
changed the title
|
Ah thanks to know, well updated PR scope and focus on where Option serialization helpers are effectively usable I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop Box usage in remote_claimabe_outpoint
Should have been address in #271, don't get the Box usage and afferent heap consumption, is there a murky reason ? (tested on 1.22 too)