Create script file for easy local linting #3339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3339 +/- ##
=======================================
Coverage 89.60% 89.60%
=======================================
Files 127 127
Lines 103531 103531
Branches 103531 103531
=======================================
+ Hits 92767 92770 +3
+ Misses 8064 8060 -4
- Partials 2700 2701 +1 ☔ View full report in Codecov by Sentry. |
arik-so
commented
Sep 26, 2024
ci/check-lint.sh
Outdated
| #!/bin/sh | ||
| set -e | ||
| set -x | ||
| rustup component add clippy |
There was a problem hiding this comment.
lmk if you think clippy installation should be part of the script
There was a problem hiding this comment.
Assuming that add clippy is a NOP when running the script, LGTM
There was a problem hiding this comment.
yup, without --force it should be idempotent
There was a problem hiding this comment.
IMO this should keep living in CI, as we don't want to have the script mess with the local installation.
|
LGTM, feel free to rebase + squash and lets land this. |
arik-so
force-pushed
the
lint-script-file
branch
from
c102b6c to
46c2c81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.