Remove UserConfig::accept_mpp_keysend
#3439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option was added to force users to opt into breaking compat with < 0.0.116, so it should be fine to remove for the 0.1 release. Otherwise, receiving to static invoices would always require flipping this on.
valentinewallace
force-pushed
the
2024-12-remove-mpp-keysend-cfg
branch
from
05a59a4 to
2e685ff
Compare
Thanks, done |
dunxen
approved these changes
Dec 5, 2024
TheBlueMatt
approved these changes
Dec 5, 2024
valentinewallace
commented
Dec 5, 2024
| @@ -901,7 +889,6 @@ impl Readable for UserConfig { | |||
| accept_inbound_channels: Readable::read(reader)?, | |||
| manually_accept_inbound_channels: Readable::read(reader)?, | |||
| accept_intercept_htlcs: Readable::read(reader)?, | |||
| accept_mpp_keysend: Readable::read(reader)?, | |||
There was a problem hiding this comment.
Hey sorry, I think this might be why fuzz failed? Looking into it
There was a problem hiding this comment.
Probably the no-changes test failed?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was added to force users to opt into breaking compat with < 0.0.116, so it should be fine to remove for the 0.1 release. Otherwise, receiving to static invoices would always require flipping this on.