Skip to content

chore: make Bolt11InvoiceDescriptionRef copy #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

elsirion
Copy link
Contributor

@elsirion elsirion commented Dec 5, 2024

Just a minor API paper cut fix, will lead to less .clone()ing.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.65%. Comparing base (797993c) to head (64a3bd6).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3445      +/-   ##
==========================================
- Coverage   89.69%   89.65%   -0.05%     
==========================================
  Files         130      130              
  Lines      107335   107265      -70     
  Branches   107335   107265      -70     
==========================================
- Hits        96277    96166     -111     
- Misses       8658     8689      +31     
- Partials     2400     2410      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheBlueMatt TheBlueMatt merged commit 529cbed into lightningdevkit:main Dec 5, 2024
18 of 19 checks passed
@elsirion elsirion deleted the 2024-12-copy-description branch December 5, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants