Skip to content

Rustfmt events #3773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025
Merged

Rustfmt events #3773

merged 2 commits into from
May 12, 2025

Conversation

joostjager
Copy link
Contributor

@joostjager joostjager commented May 12, 2025

Noticing the no-rustfmt penalty again when working on bump_transaction.rs. These files look completely fine to me as is.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented May 12, 2025

👋 Thanks for assigning @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@@ -5,8 +5,6 @@ lightning/src/chain/mod.rs
lightning/src/chain/onchaintx.rs
lightning/src/chain/package.rs
lightning/src/chain/transaction.rs
lightning/src/events/bump_transaction.rs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess this basically conflicts with your PR and it hasn't gotten to review yet so seems fine to do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do the magic script, no problem

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@joostjager
Copy link
Contributor Author

@TheBlueMatt squashed your changes and rustfmt'ed the formatting fixes.

Comment on lines -188 to +193
None => {
Ok(PaymentPurpose::Bolt11InvoicePayment {
payment_preimage,
payment_secret,
})
},
Some(PaymentContext::Bolt12Offer(context)) => {
Ok(PaymentPurpose::Bolt12OfferPayment {
payment_preimage,
payment_secret,
payment_context: context,
})
},
None => Ok(PaymentPurpose::Bolt11InvoicePayment { payment_preimage, payment_secret }),
Some(PaymentContext::Bolt12Offer(context)) => Ok(PaymentPurpose::Bolt12OfferPayment {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rustfmt made something less vertical 😮

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does do that quite often, tho sometimes when it does that I find it annoying 😂

Copy link
Contributor

@dunxen dunxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the same diff with rustfmt, and doesn't seem horrendous to me so LGTM

TheBlueMatt
TheBlueMatt approved these changes May 12, 2025
@TheBlueMatt TheBlueMatt merged commit 5316257 into lightningdevkit:main May 12, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants