-
Notifications
You must be signed in to change notification settings - Fork 412
Rustfmt events #3773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustfmt events #3773
Conversation
👋 Thanks for assigning @valentinewallace as a reviewer! |
@@ -5,8 +5,6 @@ lightning/src/chain/mod.rs | |||
lightning/src/chain/onchaintx.rs | |||
lightning/src/chain/package.rs | |||
lightning/src/chain/transaction.rs | |||
lightning/src/events/bump_transaction.rs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess this basically conflicts with your PR and it hasn't gotten to review yet so seems fine to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do the magic script, no problem
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Co-authored-by: Matt Corallo <[email protected]>
ee8df0d
to
c9624fc
Compare
@TheBlueMatt squashed your changes and rustfmt'ed the formatting fixes. |
None => { | ||
Ok(PaymentPurpose::Bolt11InvoicePayment { | ||
payment_preimage, | ||
payment_secret, | ||
}) | ||
}, | ||
Some(PaymentContext::Bolt12Offer(context)) => { | ||
Ok(PaymentPurpose::Bolt12OfferPayment { | ||
payment_preimage, | ||
payment_secret, | ||
payment_context: context, | ||
}) | ||
}, | ||
None => Ok(PaymentPurpose::Bolt11InvoicePayment { payment_preimage, payment_secret }), | ||
Some(PaymentContext::Bolt12Offer(context)) => Ok(PaymentPurpose::Bolt12OfferPayment { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rustfmt made something less vertical 😮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does do that quite often, tho sometimes when it does that I find it annoying 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the same diff with rustfmt, and doesn't seem horrendous to me so LGTM
Noticing the no-rustfmt penalty again when working on bump_transaction.rs. These files look completely fine to me as is.