attempt to create API for regular Pings

[Aleru]

Let me know if there are any revisions you would like or things I should do differently next time.

[TheBlueMatt]

Hmm, our runtime model prevents us from spawning threads. Instead, we should probably try to model this as simply a function that the *user* calls every minute or so. Inside it we should walk the peer list, check if a pending ping didn’t get a response (and disconnect them), and generate new pings for every power.

…

On Oct 18, 2019, at 21:08, Aleru ***@***.***> wrote:  You can view, comment on, or merge this pull request online at: #382 Commit Summary Merge pull request #1 from rust-bitcoin/master first add updateS add commit commit updates s fixed first bug :D fixed bug for real this time... probably should read docs of related structures before i begin hacking coming along nicely need docs and test updates commit x n another update cleaning it up a bit for groupwork more cleaning :P add todot remove no longer relevant comment fixed issue of disconnecting peer removed extra comment probably ready for PR ready for pr... for real this time! ready for pr act 3 ready for pr act 4 File Changes M src/ln/peer_handler.rs (170) Patch Links: https://github.com/rust-bitcoin/rust-lightning/pull/382.patch https://github.com/rust-bitcoin/rust-lightning/pull/382.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[Aleru]

Sounds good, If I understand you correctly the final function would look something like this:

pub fn check_peers(&mut self) -> Result<(), PeerHandleError> {
disconnect_if_no_pong(self); //disconnect if there is no pong in a Peers pending_read_buffer
ping_peers(); // put a ping message in every peers pending outbound buffer
}

A couple notes/concerns though

If I understand correctly the desired implementation would require the user to generate the very first Ping message (I am assuming this is okay).

The disconnect_if_no_pong function (at least the way it is currently written) does not really have any knowledge of specific ping messages it just scans a copy of the pending_read_buffer looking for anything that resembles a pong message, if there is no pong-like message it removes the Peer from PeerHolder. It seems really sketchy that I manually removed (calling the remove method on the hashmap) the Peer from Peerholder.peers as opposed to using some prewritten functionality (I could not find anything that worked so i just manually removed the Peer).

The disconnect_if_no_pong function also does not clear the Pong messages from the pending_read_buffer either, should i be concerned that they will build up and never be removed?

[Aleru]

Ouch, I think i will try using GUI. please go ahead and disregard all the commits I don't really know what is going on.