Fulfill error handling for send_commitment in processing htlcs forward #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good at a high level, but is desperately in need of some DRY. At least use the existing break_chan_entry! macro for the first hunk (which it looks like it was copied out of?), though the match after handle_error also could be DRY'd across channelmanager (its not unique/introduced here, though, so if you dont want to do it in this PR thats fine.). |
|
Yes was my feeling to DRY too, let's get #390 first, then on top of that I've another commit to simplify error management on the whole. From then, will get us better hint on how to DRY the whole |
|
SGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.