Clean up documentation around spendable outputs significantly. #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariard
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
Thanks for documenting forward, LGTM.
That's said we may need more specified stuff, at least internally to remove private keys from memory.
May we have to specify output script descriptor with Lightning derivation path like revokeable(<index>). If we assume signer knows basepoint, that should be easy it just have to implement bolt 3 derivation.
* Fixed a number of grammar issues * Clarified the docs for users who are intimately farmiliar with arbitrary lines of text copied from the BOLTs * Added a bit more text so that things are easier to read and less disjoint. * Clarified exactly how the witness stack should look since I had to go dig for it.
TheBlueMatt
force-pushed
the
2020-01-spendable-docs
branch
from
9f56a43 to
6c9180f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arbitrary lines of text copied from the BOLTs
disjoint.
to go dig for it.