remove decode_error macro only used once #478
Conversation
| let message_result = wire::read(&mut reader); | ||
| let message = match message_result { |
There was a problem hiding this comment.
You can simplify these two lines as:
let message = match wire::read(&mut reader) {Or use the name message in both assignments to shadow the first variable, as that is idiomatic in Rust.
There was a problem hiding this comment.
True. Although I would argue it might be easier for readers and debuggers to have the match input be a variable as opposed to a method call. What do you think?
There was a problem hiding this comment.
I don't have a strong opinion on that. For the readability standpoint, the let x = match <exp> { Ok(x) => x, Err(e) => { ... } } pattern is common enough to know that the expression evaluates to a Result. And given that, one variable removes redundancy. Regarding debugging, knowing which arm is hit should be enough.
Anyhow, feel free to leave as is if you feel strongly.
|
Gonna merge this as its obviously better than it was and upcoming refactors in this area should give ample opportunity to get it Just Right (tm). |
No description provided.