Fix one-confirmation funding_locked generation #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously tracked funding transaction confirmation by marking funding_tx_confirmations to 1 when we see it in a block and incrementing each block thereafter if its non-0. To avoid double-incrementing the first confirmation, we did the increment (and funding_locked check) after doing the first-confirmation checks. Thus, we'd never hit the funding_locked case during the first confirmation. To address this, we simply swap the order of the checks, though bumping the funding_tx_confirmations increment up to the top. Reported-by: Igor Cota <[email protected]>
ariard
reviewed
Feb 11, 2020
| if header.bitcoin_hash() != self.last_block_connected { | ||
| self.last_block_connected = header.bitcoin_hash(); | ||
| self.channel_monitor.last_block_hash = self.last_block_connected; | ||
| if self.funding_tx_confirmations > 0 { |
There was a problem hiding this comment.
Do we want to support zero-conf channels ? If so we should remove this check I guess.
There was a problem hiding this comment.
Yes, in theory I think we do, but it probably shouldnt be with this API - we should do some kind of risk API that lets you limit exposure to 0confs and such...I havent thought much about how to structure it, yet, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @icota.