[chaininterface] Add ability for BlockNotifier to unregister listeners #502
+88
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rloomba
force-pushed
the
rloomba/add_unregister_listener
branch
from
5b7690a to
9bfcac6
Compare
TheBlueMatt
reviewed
Feb 17, 2020
| block_notifier.register_listener(listener); | ||
| let vec = block_notifier.listeners.lock().unwrap(); | ||
| assert_eq!(vec.len(), 1); | ||
| let item = vec.first().clone().unwrap(); |
There was a problem hiding this comment.
Can you add a test that you can deregister node_cfgs[0].chan_monitor.simple_monitor itself instead of just the thing that was pulled out of the registration list?
There was a problem hiding this comment.
I'm not sure I fully understand what you mean by
instead of just the thing that was pulled out of the registration list
Do you mean calling unregister_listener and passing in node_cfgs[0].chan_monitor.simple_monitor itself instead of the listener1 local variable?
If so, I wrote a new test unregister_single_listener_ref_test, otherwise would love some guidance.
There was a problem hiding this comment.
Thats exactly what I meant.
…ered listener, in order to no longer receive events
rloomba
force-pushed
the
rloomba/add_unregister_listener
branch
from
9bfcac6 to
7d62346
Compare
TheBlueMatt
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #473.
Note: If a user has registered the same listener multiple times,
unregister_listenerwill remove all occurrences of that listener.