CI and rustc warning cleanup #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems we've recently been seeing sporadic long-running full_stack_target cases when running honggfuzz in CI. These shouldn't be killed (as its possible they hit an error or a deadlock, especially since the longest-running tests probably have the most coverage).
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
==========================================
- Coverage 91.05% 91.05% -0.01%
==========================================
Files 34 34
Lines 20357 20357
==========================================
- Hits 18537 18536 -1
- Misses 1820 1821 +1
Continue to review full report at Codecov.
|
valentinewallace
approved these changes
Apr 24, 2020
| @@ -1,7 +1,6 @@ | |||
| name: Continuous Integration Checks | |||
|
|
|||
| on: | |||
| push: | |||
| on: [push, pull_request] | |||
There was a problem hiding this comment.
ah, I had mistakenly assumed push would encompass pull_request..
There was a problem hiding this comment.
Yep, I just came back to master to fix that as I realised it was needed for fork PRs. Well done @TheBlueMatt :)
| @@ -91,7 +90,7 @@ jobs: | |||
| run: | | |||
| sudo apt-get update | |||
| sudo apt-get -y install build-essential binutils-dev libunwind-dev | |||
| - name: Fuzz test on Rust ${{ matrix.TOOLCHAIN }} | |||
| - name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few things about the new Github Actions CI, fixes our CI fuzz stuff, and some rustc compile-time warnings.