Refactor dependencies

[dr-orlovsky]

This code adopts new bitcoin hash types and migrates on the latest crate version, i.e. closes #578

Since bitcoin crate includes both bitcoin_hashes and secp256k1, this creates dependency conflicts in projects using rust-lightning. So I have started with removing this additional dependencies in the first two commits before adopting new hash type system

[codecov]

Codecov Report

Merging #609 into master will decrease coverage by 0.03%.
The diff coverage is 97.72%.

@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
- Coverage   91.10%   91.06%   -0.04%     
==========================================
  Files          34       34              
  Lines       20447    20457      +10     
==========================================
+ Hits        18628    18629       +1     
- Misses       1819     1828       +9     

Impacted Files	Coverage Δ
lightning/src/lib.rs	100.00% <ø> (ø)
lightning/src/ln/chanmon_update_fail_tests.rs	97.34% <ø> (ø)
lightning/src/ln/onion_utils.rs	95.02% <ø> (ø)
lightning/src/ln/peer_channel_encryptor.rs	94.40% <ø> (ø)
lightning/src/ln/peer_handler.rs	56.29% <ø> (ø)
lightning/src/util/chacha20poly1305rfc.rs	97.95% <ø> (ø)
lightning/src/util/enforcing_trait_impls.rs	100.00% <ø> (ø)
lightning/src/util/events.rs	20.43% <ø> (ø)
lightning/src/util/macro_logger.rs	89.28% <ø> (ø)
lightning/src/util/ser_macros.rs	96.59% <ø> (ø)
... and 16 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12e2a81...dde344a. Read the comment docs.

[jkczyz]

This is first part of my work on migration to the new bitcoin crate version.

Thanks for going about this refactoring! Any chance you could open an issue for the migration if it doesn't exist yet?

[dr-orlovsky]

@jkczyz sorry, not entirely get what do you mean by the issue. This one? #578

[jkczyz]

Yes, thank you. Referencing the existing issue in the PR description is sufficient. Let me know when the PR is ready for review.

[dr-orlovsky]

It is ready!

[jb55]

as someone who has done this refactor in a few of my own projects and looking over this... very nice! utACK c04a038

[TheBlueMatt]

Looks good, two minor comments and please squash the fixup commit into the relevant commits so that each commit individually builds/passes tests.

[jkczyz]

Concur with @TheBlueMatt regarding the fixup commits. Otherwise, looks good!