Use our actual feerate in open_channel messages, not a new one #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
reviewed
Jun 13, 2020
arik-so
approved these changes
Jun 15, 2020
valentinewallace
force-pushed
the
fix-feerate-new-channel
branch
2 times, most recently
from
359de55 to
981cd9f
Compare
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
==========================================
+ Coverage 91.26% 91.28% +0.01%
==========================================
Files 35 35
Lines 21122 21138 +16
==========================================
+ Hits 19278 19295 +17
+ Misses 1844 1843 -1
Continue to review full report at Codecov.
|
Fixed! |
valentinewallace
force-pushed
the
fix-feerate-new-channel
branch
from
16db924 to
4b6b68a
Compare
When we were sending an open_channel messages we were asking the feerate estimator for a new value instead of using the one we had. If the feerate estimator gave a different value than the one it did when we created the Channel struct, we'd start out-of-sync with our counterparty and blow up on funding_signed. Even worse, the ConfirmationTarget used was different, so its highly likely they would disagree. Also remove newly unused fee estimator parameter from get_open-channel API. Co-authored-by: Matt Corallo <[email protected]> Co-authored-by: Valentine Wallace <[email protected]>
valentinewallace
force-pushed
the
fix-feerate-new-channel
branch
2 times, most recently
from
d47cfcd to
ca96c87
Compare
TheBlueMatt
reviewed
Jun 16, 2020
The protocol only allows a u32, so if we received or sent something larger it would be an issue (though it's unlikely).
valentinewallace
force-pushed
the
fix-feerate-new-channel
branch
from
48ccae1 to
f917187
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we were sending an open_channel messages we were asking the
feerate estimator for a new value instead of using the one we had.
If the feerate estimator gave a different value than the one it did
when we created the Channel struct, we'd start out-of-sync with our
counterparty and blow up on funding_signed. Even worse, the
ConfirmationTarget used was different, so its highly likely they
would disagree.
Also remove newly unused fee estimator parameter from get_open-channel
API.