Skip to content

ChannelKeys provides individual commitment secrets #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devrandom
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #652 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
- Coverage   91.31%   91.30%   -0.01%     
==========================================
  Files          35       35              
  Lines       21225    21230       +5     
==========================================
+ Hits        19381    19385       +4     
- Misses       1844     1845       +1     
Impacted Files Coverage Δ
lightning/src/chain/keysinterface.rs 94.81% <100.00%> (+0.03%) ⬆️
lightning/src/ln/chan_utils.rs 97.17% <100.00%> (ø)
lightning/src/ln/channel.rs 86.77% <100.00%> (ø)
lightning/src/ln/functional_tests.rs 97.29% <100.00%> (+<0.01%) ⬆️
lightning/src/util/enforcing_trait_impls.rs 100.00% <100.00%> (ø)
lightning/src/ln/channelmonitor.rs 95.63% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd13364...1d37f56. Read the comment docs.

@devrandom devrandom force-pushed the commitment-secret branch from e7ae3de to 1d37f56 Compare July 1, 2020 18:55
@ariard
Copy link

ariard commented Jul 1, 2020

Code Review ACK 1d37f56

@TheBlueMatt TheBlueMatt merged commit bb369b5 into lightningdevkit:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants