Actually hold the total_consistency_lock instead of take-and-drop #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was noticed (via clippy) by @casey that we were taking and then immediately dropping the total_consistency_lock because `let _ =` doesn't actually bind the response to anything. This appears to be a consequence of wanting `if let Some(_) =` to not hold a ref to the contained value at all, but is relatively surprising to me.
valentinewallace
approved these changes
Oct 2, 2020
|
Wow that's insidious. Seems like a footgun. |
jkczyz
approved these changes
Oct 2, 2020
|
We didn't hold oh ? Post-merge Code Review ACK ddebf36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was noticed (via clippy) by @casey that we were taking and then
immediately dropping the total_consistency_lock because
let _ =doesn't actually bind the response to anything. This appears to be
a consequence of wanting
if let Some(_) =to not hold a ref tothe contained value at all, but is relatively surprising to me.
Sadly, this case is super hard to test and, worse, clippy isn't even supported without rustup, making it hard to integrate clippy into (at least my) workflow.