Don't let CI fail to check commits b/c git isn't configured in CI #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2020-10-ci-no-git-conf
branch
from
1fdd5ef to
867af52
Compare
This fixes lightningdevkit#733 by just setting a dummy git name/email before calling `git rebase` in CI.
TheBlueMatt
force-pushed
the
2020-10-ci-no-git-conf
branch
from
867af52 to
89e40fe
Compare
|
Code Review ACK 89e40fe, CI is triggered while the branch being based on old master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #733 by just setting a dummy git name/email before
calling
git rebasein CI.This PR is deliberately based on a stale version of git upstream to test it.