Fix passing -O1 to build from cargo test
#738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2020-10-opt-test
branch
from
1129b2c to
bbf2c32
Compare
jkczyz
approved these changes
Oct 5, 2020
In 9e03087 we started setting `opt-level` only on profile.test and not profile.dev. When that commit was authored I tested only that rustc was being called with opt-level set in its flags, not that the resulted run ran at the speed I expected. It seems profile.test isn't applied properly to dependencies or so, resulting in tests running much slower than they do at profile.dev.opt-level=1.
TheBlueMatt
force-pushed
the
2020-10-opt-test
branch
from
bbf2c32 to
e808d50
Compare
Codecov Report
@@ Coverage Diff @@
## main #738 +/- ##
==========================================
- Coverage 91.94% 91.34% -0.60%
==========================================
Files 37 37
Lines 20108 21964 +1856
==========================================
+ Hits 18489 20064 +1575
- Misses 1619 1900 +281
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 9e03087 we started setting
opt-levelonly on profile.test and not profile.dev. When thatcommit was authored I tested only that rustc was being called with
opt-level set in its flags, not that the resulted run ran at the
speed I expected. It seems profile.test isn't applied properly to
dependencies or so, resulting in tests running much slower than
they do at profile.dev.opt-level=1.