Skip to content

Raise max to_self_delay. #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

valentinewallace
Copy link
Contributor

lnd requires this to_self_delay for the max channel size
(excluding wumbo).

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs in config.rs need updating "lightning/src/util/config.rs:132: /// Default value: MAX_LOCAL_BREAKDOWN_TIMEOUT (1008), which we also enforce as a maximum value
" (though that shouldn't mention the non-public constant, either).

@valentinewallace valentinewallace force-pushed the raise-max-to-self-delay branch from 0a0956e to c0aed9b Compare March 4, 2021 18:45
@valentinewallace
Copy link
Contributor Author

Thanks missed that, updated.

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #826 (633c327) into main (8b4ea56) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #826   +/-   ##
=======================================
  Coverage   90.97%   90.97%           
=======================================
  Files          48       48           
  Lines       26538    26540    +2     
=======================================
+ Hits        24144    24146    +2     
  Misses       2394     2394           
Impacted Files Coverage Δ
lightning/src/ln/channelmanager.rs 85.47% <ø> (ø)
lightning/src/util/config.rs 48.78% <ø> (ø)
lightning/src/chain/chainmonitor.rs 93.93% <100.00%> (-0.27%) ⬇️
lightning/src/chain/channelmonitor.rs 95.54% <100.00%> (+0.01%) ⬆️
lightning/src/ln/functional_tests.rs 96.88% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b4ea56...b75437d. Read the comment docs.

Copy link
Contributor

@arik-so arik-so left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The missing units in the comments are not due to this PR, but I think this PR should absolutely fix them for future readers. Other than that, LGTM.

bmancini55 added a commit to bmancini55/rust-lightning that referenced this pull request Mar 5, 2021
LN Spec PR lightningdevkit#826 changes full_information to indicate completion of a
sequence of reply_channel_range messages.
@TheBlueMatt TheBlueMatt added this to the 0.0.13 milestone Mar 5, 2021
@TheBlueMatt
Copy link
Collaborator

Calling it 0.0.13 because it appears we need this to reasonably open channels live today, which is probably worth merging before shipping a release that can't practically be used.

lnd requires this to_self_delay for the max channel size
(excluding wumbo).
@valentinewallace valentinewallace force-pushed the raise-max-to-self-delay branch from c0aed9b to b75437d Compare March 8, 2021 22:30
@TheBlueMatt TheBlueMatt merged commit 2cb655b into lightningdevkit:main Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants