-
Notifications
You must be signed in to change notification settings - Fork 411
Raise max to_self_delay. #826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise max to_self_delay. #826
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs in config.rs need updating "lightning/src/util/config.rs:132: /// Default value: MAX_LOCAL_BREAKDOWN_TIMEOUT (1008), which we also enforce as a maximum value
" (though that shouldn't mention the non-public constant, either).
0a0956e
to
c0aed9b
Compare
Thanks missed that, updated. |
Codecov Report
@@ Coverage Diff @@
## main #826 +/- ##
=======================================
Coverage 90.97% 90.97%
=======================================
Files 48 48
Lines 26538 26540 +2
=======================================
+ Hits 24144 24146 +2
Misses 2394 2394
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The missing units in the comments are not due to this PR, but I think this PR should absolutely fix them for future readers. Other than that, LGTM.
LN Spec PR lightningdevkit#826 changes full_information to indicate completion of a sequence of reply_channel_range messages.
Calling it 0.0.13 because it appears we need this to reasonably open channels live today, which is probably worth merging before shipping a release that can't practically be used. |
lnd requires this to_self_delay for the max channel size (excluding wumbo).
c0aed9b
to
b75437d
Compare
lnd requires this to_self_delay for the max channel size
(excluding wumbo).