Skip to content

Fix benchmark compile warnings and errors #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

TheBlueMatt
Copy link
Collaborator

Hopefully soon once a few more PRs get merged we can require this
in CI so we won't have any more regressions here.

Hopefully soon once a few more PRs get merged we can require this
in CI so we won't have any more regressions here.
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #875 (daa1979) into main (8088e4b) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
+ Coverage   90.20%   90.22%   +0.02%     
==========================================
  Files          55       55              
  Lines       28913    28994      +81     
==========================================
+ Hits        26080    26160      +80     
- Misses       2833     2834       +1     
Impacted Files Coverage Δ
lightning/src/ln/channelmanager.rs 83.04% <ø> (ø)
lightning/src/routing/router.rs 95.79% <ø> (ø)
background-processor/src/lib.rs 95.77% <0.00%> (-0.23%) ⬇️
lightning/src/ln/functional_tests.rs 96.86% <0.00%> (+0.01%) ⬆️
lightning-persister/src/lib.rs 96.20% <0.00%> (+1.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8088e4b...daa1979. Read the comment docs.

Copy link
Contributor

@valentinewallace valentinewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we fix this warning in benchmark: https://i.imgur.com/Zm4JLwj.png while we're at it? (Disregard if we're choosing not to fix it for whatever reason)

@TheBlueMatt
Copy link
Collaborator Author

Should we fix this warning in benchmark: https://i.imgur.com/Zm4JLwj.png while we're at it? (Disregard if we're choosing not to fix it for whatever reason)

Sure, why not.

@TheBlueMatt TheBlueMatt merged commit eee1c30 into lightningdevkit:main Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants