Prepare lightning-invoice for export in C #903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2021-04-invoice-bindings
branch
from
76edfd3 to
4f73f7e
Compare
Codecov Report
@@ Coverage Diff @@
## main #903 +/- ##
==========================================
+ Coverage 90.38% 90.42% +0.03%
==========================================
Files 57 57
Lines 29500 29500
==========================================
+ Hits 26665 26676 +11
+ Misses 2835 2824 -11
Continue to review full report at Codecov.
|
valentinewallace
approved these changes
Apr 28, 2021
There is generally never a reason to return a non-mutable reference to a u64 vs just copying it, same applies here. It makes the API slightly less consistent, but is easier to map in bindings and just makes more sense.
This prevents aliasing the global secp256k1::Signature name in C bindings and also makes it a little more explicit that the object is different from other signature types.
TheBlueMatt
force-pushed
the
2021-04-invoice-bindings
branch
from
4f73f7e to
2484c1a
Compare
|
Oops, pushed one more commit to prevent aliasing two |
The ChannelSigner bounds are specified both in `impl<>` and in the `where` clause, which the C bindings generator doesn't like. There is no reason to have them specified twice.
|
Added a commit which isn't related to invoices, but is required for some bits of lightning bindings. |
jkczyz
approved these changes
Apr 29, 2021
|
This is all super trivial, gonna merge so we can get invoice bindings out ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly just C-no export tags. I have a bindings branch that can build bindings given these tags, modulo one or two small things and adding u5 support in Java.