Skip to content

Remove Send and Sync from core crate #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

devrandom
Copy link
Member

Related to #842

@devrandom devrandom requested a review from TheBlueMatt April 29, 2021 19:08
@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #904 (ec35fe6) into main (cb0b4bf) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #904      +/-   ##
==========================================
+ Coverage   90.37%   90.39%   +0.01%     
==========================================
  Files          57       57              
  Lines       29500    29500              
==========================================
+ Hits        26662    26666       +4     
+ Misses       2838     2834       -4     
Impacted Files Coverage Δ
lightning-block-sync/src/poll.rs 92.04% <ø> (ø)
lightning-net-tokio/src/lib.rs 76.42% <ø> (ø)
lightning/src/chain/chainmonitor.rs 95.52% <ø> (ø)
lightning/src/chain/channelmonitor.rs 95.45% <ø> (ø)
lightning/src/chain/keysinterface.rs 93.62% <ø> (ø)
lightning/src/chain/mod.rs 100.00% <ø> (ø)
lightning/src/ln/channelmanager.rs 83.42% <ø> (ø)
lightning/src/ln/msgs.rs 88.76% <ø> (ø)
lightning/src/routing/network_graph.rs 91.86% <ø> (ø)
lightning/src/util/logger.rs 57.14% <ø> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb0b4bf...ec35fe6. Read the comment docs.

@TheBlueMatt TheBlueMatt merged commit 38a544e into lightningdevkit:main Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants