Minor Tweaks to lightning-invoice for C bindings #908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C bindings generator now looks to default generic types as the way to map a struct or enum parameter. Because SignOrCreationError is only used directly with an error type of `()`, we set that to the default and assume no other error types are needed.
... due to A and A aliasing each other.
Codecov Report
@@ Coverage Diff @@
## main #908 +/- ##
==========================================
+ Coverage 90.50% 90.51% +0.01%
==========================================
Files 59 59
Lines 29624 29624
==========================================
+ Hits 26810 26813 +3
+ Misses 2814 2811 -3
Continue to review full report at Codecov.
|
jkczyz
approved these changes
Apr 30, 2021
ariard
reviewed
May 1, 2021
While this is less readable, I spent way too long trying to adapt the bindings generation code to handle glob imports and concluded it would take refactoring almost the entire import-resolution logic. While this may be a good refactor to do eventually, its probably not worth it today.
RawHrp is already not-exported, so implementations for it should be as well.
TheBlueMatt
force-pushed
the
2021-04-invoice-real-bindings
branch
from
54c97ee to
83ab933
Compare
|
Squashed one fixup commit without diff. Will merge after CI |
arik-so
approved these changes
May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This + lightningdevkit/ldk-c-bindings#19 correctly builds the new invoice construction utility method for C (+Java).