Skip to content

Correct default invoice expiry #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

valentinewallace
Copy link
Contributor

We previously stated in the codebase that the default invoice expiry
stated in the spec is 2 hours. It's actually 1 hour.

Relevant spec: https://github.com/lightningnetwork/lightning-rfc/blob/master/11-payment-encoding.md#tagged-fields

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #922 (4503ef3) into main (0b1f0a7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #922      +/-   ##
==========================================
- Coverage   90.46%   90.45%   -0.02%     
==========================================
  Files          59       59              
  Lines       29789    29742      -47     
==========================================
- Hits        26950    26904      -46     
+ Misses       2839     2838       -1     
Impacted Files Coverage Δ
lightning/src/ln/channelmanager.rs 83.33% <ø> (ø)
lightning-invoice/src/utils.rs 83.87% <100.00%> (+0.17%) ⬆️
lightning-block-sync/src/rest.rs 65.45% <0.00%> (-1.79%) ⬇️
lightning-block-sync/src/rpc.rs 78.37% <0.00%> (-1.11%) ⬇️
lightning-block-sync/src/poll.rs 91.66% <0.00%> (-0.38%) ⬇️
lightning-block-sync/src/lib.rs 95.18% <0.00%> (-0.20%) ⬇️
lightning-net-tokio/src/lib.rs 76.25% <0.00%> (-0.17%) ⬇️
lightning-block-sync/src/init.rs 93.56% <0.00%> (-0.15%) ⬇️
lightning-block-sync/src/http.rs 95.00% <0.00%> (-0.13%) ⬇️
lightning/src/ln/functional_tests.rs 96.84% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b1f0a7...4503ef3. Read the comment docs.

We previously stated in the codebase that the default invoice expiry
stated in the spec is 2 hours. It's actually 1 hour.
@valentinewallace valentinewallace force-pushed the update-default-expiry branch from 4d24f63 to 4503ef3 Compare May 14, 2021 20:52
@TheBlueMatt TheBlueMatt merged commit eeabac8 into lightningdevkit:main May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants