Skip to content

Use core replacements for std members #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2021

Conversation

GeneFerneau
Copy link
Contributor

In preparation for no_std build support, replace std structs and functions with core equivalents

In preparation for no_std build support, replace std structs and
functions with core equivalents
@GeneFerneau GeneFerneau changed the title Use core replacments for std members Use core replacements for std members May 23, 2021
Copy link
Member

@devrandom devrandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #926 (ec3739b) into main (b6de281) will decrease coverage by 0.01%.
The diff coverage is 90.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #926      +/-   ##
==========================================
- Coverage   90.48%   90.46%   -0.02%     
==========================================
  Files          59       59              
  Lines       29896    29896              
==========================================
- Hits        27050    27046       -4     
- Misses       2846     2850       +4     
Impacted Files Coverage Δ
lightning/src/chain/chainmonitor.rs 95.52% <ø> (ø)
lightning/src/chain/mod.rs 100.00% <ø> (ø)
lightning/src/ln/chan_utils.rs 97.34% <ø> (ø)
lightning/src/ln/channelmanager.rs 83.55% <ø> (+0.08%) ⬆️
lightning/src/ln/features.rs 98.83% <ø> (ø)
lightning/src/ln/functional_tests.rs 96.80% <ø> (-0.10%) ⬇️
lightning/src/ln/msgs.rs 88.22% <ø> (ø)
lightning/src/ln/onion_route_tests.rs 96.80% <ø> (ø)
lightning/src/ln/onion_utils.rs 94.90% <ø> (ø)
lightning/src/ln/reorg_tests.rs 99.62% <ø> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6de281...ec3739b. Read the comment docs.

@TheBlueMatt TheBlueMatt merged commit c7e198e into lightningdevkit:main May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants