feat(shell): allow configuring ssh alias #1132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
reviewed
Oct 25, 2022
cmd/limactl/shell.go
Outdated
| var arg0Args []string | ||
|
|
||
| if sshShell := os.Getenv(envShellSSH); sshShell != "" { | ||
| sshShellFields := strings.Fields(sshShell) |
There was a problem hiding this comment.
Should this split the string using shell quoting semantics?
I don't know if there is a recommended function for it, but a quick search found
This seems to do what I would expect, but I haven't actually looked at the implementation:
shlex.Split("one \"two three\" four") -> []string{"one", "two three", "four"}
There was a problem hiding this comment.
I had simple use cases in mind, but you're raising an excellent point.
There was a problem hiding this comment.
Done in b6645274..5ca81769.
PTAL
This comment was marked as outdated.
This comment was marked as outdated.
AkihiroSuda
reviewed
Oct 28, 2022
antoineco
requested review from
jandubois and
AkihiroSuda
and removed request for
jandubois and
AkihiroSuda
AkihiroSuda
reviewed
Nov 2, 2022
If the LIMASHELL_SSH environment variable is set, 'limactl shell' will consider this as an alias for the 'ssh' command to execute, instead of looking up a 'ssh' executable in the PATH. The provided command can be anything that is CLI-compatible with the OpenSSH client, such as a shell script that passes all provided arguments to 'ssh'. Signed-off-by: Antoine Cotten <[email protected]>
jandubois
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
SSHenvironment variable is set,limactl shellwill consider this as an alias for thesshcommand to execute, instead of looking up asshexecutable in the PATH.The provided command can be anything that is CLI-compatible with the OpenSSH client, such as a shell script that passes all provided arguments to
ssh.Closes #1131
Demo