Skip to content

pkg/limayaml: remove deprecated network and useHostResolver #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AkihiroSuda
Copy link
Member

  • network: deprecated in Lima v0.7.0 (Oct 2021), in favor of networks: 07e6823
  • useHostResolver: deprecated in Lima v0.8.1 (Jan 2022), in favor of hostResolver.enabled: eaeee31

The deprecated support for VDE is not removed in this commit.


Split from https://github.com/lima-vm/lima/pull/1069/commits

- `network`: deprecated in Lima v0.7.0 (Oct 2021), in favor of `networks`:
   lima-vm@07e6823
- `useHostResolver`: deprecated in Lima v0.8.1 (Jan 2022), in favor of `hostResolver.enabled`:
   lima-vm@eaeee31

The deprecated support for VDE is not removed in this commit.

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda added this to the v0.14 milestone Nov 21, 2022
@AkihiroSuda AkihiroSuda marked this pull request as ready for review November 21, 2022 08:37
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jandubois jandubois merged commit fd55971 into lima-vm:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants