Return NODATA for IPv6 AAAA question types #1289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were replying with A response for AAAA queries which was causing an error in some clients e.g nginx. The new approach waits for 1 second and then replies with NODATA. This approach allows for more semantic reply even when client uses same Transaction ID for both A and AAAA questions. Signed-off-by: Nino Kodabande <[email protected]>
Nino-K
force-pushed
the
return-nodata-ipv6
branch
from
d2a6077 to
66b2056
Compare
jandubois
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
The change looks ok to me, and should fix the situation from rancher-sandbox/rancher-desktop#3447 (comment).
I'm slightly worried about the arbitrary delay of 1 second (why not 0.5 or 2 seconds?), but I think it should work fine as long as the machine isn't already overloaded.
@AkihiroSuda please merge, if you have no objections!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were replying with A response for AAAA queries which was causing an error in some clients e.g nginx. The new approach waits for 1 second and then replies with NODATA. This approach allows for more semantic reply even when a client uses the same Transaction ID for both A and AAAA questions.
This PR is meant to address the issue that was reported on Rancher Desktop here: rancher-sandbox/rancher-desktop#3447
Signed-off-by: Nino Kodabande [email protected]