Put machineID to the MAC address hasher + update docs + misc #139

AkihiroSuda · 2021-08-02T09:22:05Z

AkihiroSuda · 2021-08-02T10:09:49Z

After merging this one I'm gonna move the repo to https://github.com/lima-vm and release v0.6.0

.github/workflows/test.yml

jandubois · 2021-08-03T19:17:59Z

README.md

+
+The default guest IP 192.168.5.15 is not accessible from the host and other guests.
+
+To allow accessing the guest IP from the host and other virtual machines, enable [`vde_vmnet`](https://github.com/lima-vm/vde_vmnet).


Maybe reword to make clear that this will add one or more additional routable IPs to the guest. It will still not allow access "the" guest IP.

docs/network.md

jandubois · 2021-08-03T19:27:59Z

pkg/limayaml/default.yaml

+    # - url: "vde:///var/run/vde.ctl"
+    #   # VDE Switch port number (not TCP/UDP port number). Set to 65535 for PTP mode.
+    #   # Default: 0
+    #   port: 0


Maybe call it switchPort to make it more explicit? Because people may delete the comments in their own config files and then later get confused.

We already use macAddress below, so we are not aiming for the shortest possible names.

jandubois · 2021-08-03T19:32:47Z

pkg/limayaml/validate.go

+				}
+			}
+		} else if runtime.GOOS != "linux" {
+			logrus.Warnf("field %s.url is unlikely to work for %s (unless you managed to port over libvdeplug4 to %s by yourself)",


Put %s.url in backquotes.

The quoted text feels slightly snarky to me. Maybe "(unless libvdeplug4 has been ported to %s and is installed)" is more neutral?

pkg/osutil/machineid.go

jandubois

Finished my review

Signed-off-by: Akihiro Suda <[email protected]>

"5" is the magic number in the Lima ecosystem. (Visit https://en.wiktionary.org/wiki/lima and Command-F "five") But the second hex number is changed to 2 to satisfy the convention for local MAC addresses (https://en.wikipedia.org/wiki/MAC_address#Ranges_of_group_and_locally_administered_addresses) Signed-off-by: Akihiro Suda <[email protected]>

Signed-off-by: Akihiro Suda <[email protected]>

It is called "URL" so we should support at least "vde://" prefix Signed-off-by: Akihiro Suda <[email protected]>

See https://github.com/lima-vm/vde_vmnet/tree/v0.4.0#ptp-mode-switchless-mode Signed-off-by: Akihiro Suda <[email protected]>

AkihiroSuda · 2021-08-04T13:39:54Z

btw maybe we should rename url to vnl (Virtual Network Locator) to follow the latest VDE nomenclature

rd235/vdeplug4@0899842

To follow the latest VDE nomenclature. rd235/vdeplug4@0899842 Signed-off-by: Akihiro Suda <[email protected]>

jandubois

LGTM

AkihiroSuda added this to the v0.6.0 milestone Aug 2, 2021

AkihiroSuda mentioned this pull request Aug 2, 2021

Include the machine-id in the hasher to generate unique MAC addresses #135

Closed

AkihiroSuda changed the title ~~Put machineID to the MAC address hasher~~ Put machineID to the MAC address hasher + update docs + misc Aug 2, 2021

AkihiroSuda force-pushed the dev-machineid branch from c55f420 to 9134604 Compare August 2, 2021 10:08

AkihiroSuda force-pushed the dev-machineid branch 6 times, most recently from a89727d to f506f58 Compare August 3, 2021 07:30

AkihiroSuda requested a review from jandubois August 3, 2021 07:31