Support for display with vz driver #1597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balajiv113
commented
Jun 1, 2023
AkihiroSuda
reviewed
Jun 1, 2023
AkihiroSuda
reviewed
Jun 1, 2023
balajiv113
force-pushed
the
vz-display
branch
2 times, most recently
from
69a39e8 to
f9b6dfb
Compare
AkihiroSuda
reviewed
Jun 2, 2023
cmd/limactl/hostagent.go
Outdated
| @@ -32,6 +33,10 @@ func newHostagentCommand() *cobra.Command { | |||
| } | |||
|
|
|||
| func hostagentAction(cmd *cobra.Command, args []string) error { | |||
| //Without this the call to vz.StartGUI fails. Adding it here, as this has to be called before the vz cgo loads. | |||
| runtime.LockOSThread() | |||
| defer runtime.UnlockOSThread() | |||
There was a problem hiding this comment.
Can we do this only for vz mode?
There was a problem hiding this comment.
I tried options, but unfortunately could find a way to make it work.
If i move this inside hostagent it will start to panic, because once within hostagent the vz cgo and all were loaded. So only if i add before cgo loads it works else ending up in panic.
I will try to add a limayaml check directly here and see if that works
There was a problem hiding this comment.
Done the changes. Now it should impact only vz driver with display="vz"
Sending if hostagent need to run a sync ui as a command arg. In start.go deciding if we need to run a gui based on driver.
Do check it out and let me know if you have any feedback :)
AkihiroSuda
reviewed
Jun 2, 2023
Signed-off-by: Balaji Vijayakumar <[email protected]>
AkihiroSuda
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1165