Skip to content

pkg/limayaml: adjust the default CPUs and memory size #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Jun 3, 2023

CPUs: 4 → min(4, host CPU cores)
Memory: 4GiB → min(4 GiB, half of host memory)

@AkihiroSuda AkihiroSuda added this to the v0.17.0 milestone Jun 3, 2023
@AkihiroSuda AkihiroSuda mentioned this pull request Jun 3, 2023
balajiv113
balajiv113 previously approved these changes Jun 3, 2023
jandubois
jandubois previously approved these changes Jun 4, 2023
@jandubois
Copy link
Member

The change looks fine, but I'm not sure where the ¼ of total memory default comes from.

It won't make any difference for machines with 16GiB or more, but for Github runners we will move from 4GiB to 3GiB. I guess this is fine, but it is close to the minimum you need if you want to run Kubernetes inside your VM and actually run any workloads as well.

As for running Lima on an 8GiB laptop, I guess this is possible, but not very practical anyways, so using 2GiB of memory may be fine.

@AkihiroSuda
Copy link
Member Author

The change looks fine, but I'm not sure where the ¼ of total memory default comes from.

Just a random number. Let me know if 1/2 is better

@afbjorklund
Copy link
Member

we will move from 4GiB to 3GiB. I guess this is fine, but it is close to the minimum

Historically we used 1GiB for Docker Machine and 2GiB for Kubernetes (Minikube)...

I guess expectations about what the "minimum" needs, has increased since then :-)

CPUs: 4 → min(4, host CPU cores)
Memory: 4GiB → min(4 GiB, half of host memory)

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda dismissed stale reviews from jandubois and balajiv113 via 9f4c702 June 6, 2023 11:28
@AkihiroSuda AkihiroSuda force-pushed the adjust-default-resources branch from e0ec6fa to 9f4c702 Compare June 6, 2023 11:28
@AkihiroSuda
Copy link
Member Author

Changed from 1/4 to 1/2

@AkihiroSuda AkihiroSuda merged commit 85ed52a into lima-vm:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants