Skip to content

limactl (create|start|edit): add --video=<bool> #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

AkihiroSuda
Copy link
Member

No description provided.

@AkihiroSuda AkihiroSuda added the area/cli limactl CLI user experience label Jul 30, 2023
@AkihiroSuda AkihiroSuda added this to the v0.17.0 milestone Jul 30, 2023
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@AkihiroSuda AkihiroSuda merged commit 4a77a5f into lima-vm:master Jul 31, 2023
@afbjorklund
Copy link
Member

It was missing a bit of the "why" (it was promoted to top-level), or what happened to alternatives like VNC.

@AkihiroSuda
Copy link
Member Author

It was missing a bit of the "why" (it was promoted to top-level),

For ease of debugging.
E.g., showing kernel panic messages without ttyS0 (on vz)

or what happened to alternatives like VNC.

Still supported with yq mode.

@afbjorklund
Copy link
Member

afbjorklund commented Jul 31, 2023

Just wondered, since it was still mentioning the performance problems on Mac when it was enabled...

enable video output (has negative performance impact for QEMU)

@afbjorklund
Copy link
Member

Also, I added built-in support for it in the Lima GUI so now it has both Shell (SSH) and Display (VNC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli limactl CLI user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants