Skip to content

Chipers '^' syntax was added in v8.1 instead of v8.0 #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

davidcassany
Copy link
Contributor

@davidcassany davidcassany commented Nov 4, 2021

This fixes command complaints on clients using ssh v8.0, for instance, CentOS 8.4.

If you check the ChangeLog from openssh release v8.1p1 you will see the Ciphers syntax change is added there.

This fixes command complaints on clients using ssh v8.0, for
instance, CentOS 8.4.

Signed-off-by: David Cassany <[email protected]>
@davidcassany davidcassany force-pushed the fix_command_for_ssh_v8.0 branch from f1d8b72 to ee1ddd4 Compare November 4, 2021 11:53
@AkihiroSuda AkihiroSuda added this to the v0.7.4 milestone Nov 4, 2021
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@davidcassany
Copy link
Contributor Author

I am not really understanding what failed in the CI. I doubt it has relation with the changes from this PR.

@AkihiroSuda
Copy link
Member

Restarted CI, now green

@AkihiroSuda AkihiroSuda merged commit 4902c29 into lima-vm:master Nov 4, 2021
@davidcassany davidcassany deleted the fix_command_for_ssh_v8.0 branch November 4, 2021 13:37
@jandubois
Copy link
Member

If you check the ChangeLog from openssh release v8.1p1 you will see the Ciphers syntax change is added there.

Sorry, that was my fault. I thought I had verified that, but when I just looked again at the changelog, I think I must have been misreading "Changes since OpenSSH 8.0" as "Changes in OpenSSH 8.0". 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants