Add hwclock sync loop to the guestagent #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikluko
force-pushed
the
feature/hwclocksync
branch
from
1c74e71 to
5d4dc5e
Compare
AkihiroSuda
reviewed
Dec 21, 2021
AkihiroSuda
reviewed
Dec 21, 2021
mikluko
force-pushed
the
feature/hwclocksync
branch
from
5d4dc5e to
2f0286f
Compare
jandubois
previously approved these changes
Jan 8, 2022
Signed-off-by: Mikhail Lukianchenko <[email protected]>
mikluko
force-pushed
the
feature/hwclocksync
branch
from
d3f6bb5 to
dae7ddd
Compare
jandubois
previously approved these changes
Jan 10, 2022
AkihiroSuda
reviewed
Jan 11, 2022
AkihiroSuda
requested changes
Jan 11, 2022
Signed-off-by: Mikhail Lukianchenko <[email protected]>
mikluko
force-pushed
the
feature/hwclocksync
branch
from
d9c9b09 to
9d2bb68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #355
Running qemu guest agent alone doesn't solve the problem. With that approach, there must be an actor on the host side which catches wakeup events and executes RPC calls on the guest agent socket. As it stands, lima doesn't have any permanently running process to relay wake up events.
This PR offers different approach. It turns out that hardware clock device (
/dev/rtc0) forwarded into a guest by QEMU always contains correct host time. The PR adds a loop into lima guest agent. That loop periodically checks the difference between hw clock time and system time. If the diff turns out to be over certain limit (hardcoded 5 seconds for now), the loop launches time sync from hw clock to system time.