[DO NOT MERGE] Add Firewalls endpoints #105
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dorthu
reviewed
Aug 27, 2019
openapi.yaml
Outdated
| @@ -2597,6 +2597,66 @@ paths: | |||
| - lang: CLI | |||
| source: > | |||
| linode-cli domains records-delete 123 234 | |||
| /firewalls: | |||
| x-linode-cli-command: firewalls | |||
| post: | |||
There was a problem hiding this comment.
The post: object needs a servers block like this one to designate that this endpoint will be in beta when it ships.
Updates reflect latest dev changes to collection.
Add information about inbound and outbound behavior.
leslitagordita
force-pushed
the
arb-1393-docs
branch
from
3245dfc to
6376f47
Compare
leslitagordita
changed the title
alsaihn
reviewed
Sep 23, 2019
| example: 22 | ||
| addresses: | ||
| type: object | ||
| description: > |
There was a problem hiding this comment.
Can we add a note about the "all traffic" network masks here? 0.0.0.0/0 for ipv4 and ::0/0 for ipv6
Also: - Add Beta endpoint notice to GET /firewalls/:id endpoint - Change path parameter description to read something more generic, as it's shared now with DELETE
POST /networking/firewalls/{firewallId}/devices
Reviewed existing Firewall endpoints and schemas
Added:
- GET /networking/firewalls/{firewallId}/devices
- POST /networking/firewalls/{firewallId}/devices
- GET /networking/firewalls/{firewallId}/devices/{deviceId}
- DELETE /networking/firewalls/{firewallId}/devices/{deviceId}
- GET /networking/firewalls/{firewallId}/rules
- POST /networking/firewalls/{firewallId}/rules
- Refactor the start_port and end_port properties into a single ports property - Remove the ALL protocol - Copy edit of some other firewall endpoints and schemas
Inserting descriptions for these limits: - Up to three active Firewalls per Device - Up to 25 Rules per Firewall - Up to 255 addresses or networks per Rule - Up to 15 pieces in a Rule's ports string Did not include a description of how an Account's Firewall limit is the same as the Account's thing limit, as we do not describe the thing limit in other areas of the API reference.
nmelehan
reviewed
Mar 17, 2020
Comment on lines
+8468
to
+8470
| linode-cli firewalls rules-update 123 \ | ||
| --inbound '[{"protocol": "TCP", "ports": "22, 80, 8080, 443", "addresses": {"ipv4": ["192.0.2.1", "192.0.2.0/24"], "ipv6": ["2001:DB8::/32"]}}]' \ | ||
| --outbound '[{"protocol": "TCP", "ports": "49152-65535", "addresses": {"ipv4": ["192.0.2.1", "192.0.2.0/24"], "ipv6": ["2001:DB8::/32"]}}]' |
There was a problem hiding this comment.
@leslitagordita just leaving this here too; these are the lines that might need some work.
@Dorthu I'm not quite sure how to represent dictionary arguments like this in the CLI
|
closing in preference for this PR: #223 |
LBGarber
pushed a commit
to LBGarber/linode-api-docs
that referenced
this pull request
Jun 15, 2022
Release 1.0.11
LBGarber
pushed a commit
to LBGarber/linode-api-docs
that referenced
this pull request
Jun 15, 2022
Create Changelogs “4-8-0-2019-10-21”
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in Progress DO NOT MERGE