[Update] DELETE /linode/instances/{linodeId}/disks/{diskId} #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode with a currently running config profile
hzoppetti
changed the title
leslitagordita
approved these changes
Sep 4, 2019
leslitagordita
requested review from
michaelsaah
and removed request for
yoshizzle
michaelsaah
approved these changes
Sep 6, 2019
| @@ -4359,7 +4359,8 @@ paths: | |||
| - Linode Instances | |||
| summary: Delete Disk | |||
| description: | | |||
| Deletes a Disk you have permission to `read_write`. | |||
| Deletes a Disk you have permission to `read_write`. The Disk cannot be | |||
| deleted if it is attached to a Linode's running configuration profile. | |||
There was a problem hiding this comment.
this might be clearer as
The Disk cannot be deleted if it is attached to a running Linode. You can view a Linode's Disks by examining its configuration profile.
There was a problem hiding this comment.
On second thought, hold off on the above for a bit; clearing something up.
michaelsaah
suggested changes
Sep 6, 2019
There was a problem hiding this comment.
after digging into this a bit more, it seems that
- the appraisal made in the original ticket is incorrect; APIv4 allows you to delete a disk regardless of the state of the disk's linode.
- the behavior described in (1) is broken; attempting to delete a running linode's disk succeeds in the API, but fails on the backend. We need to fix this.
I recommend closing this PR.
|
@michaelsaah Okay, thanks for digging into this a bit more. Will close for now and standby for any upcoming changes. |
LBGarber
pushed a commit
to LBGarber/linode-api-docs
that referenced
this pull request
Jun 15, 2022
Release 1.0.11
LBGarber
pushed a commit
to LBGarber/linode-api-docs
that referenced
this pull request
Jun 15, 2022
…-v-0-76-0 Create Changelogs “cloud-manager-changelog-v-0-76-0”
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a note that a disk can only be deleted if not attached to a linode with a currently running config profile