Skip to content

Update deploy/tagging script #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update deploy/tagging script #115

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3abb95b
Update deploy/tagging script
nmelehan Aug 28, 2019
c576d83
fix typo
nmelehan Aug 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions bin/deploy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ else
echo "Release process is complete."
echo
echo "Once confirmed changes are verified, you can:"
echo " git push release-${version}"
echo " git push ${git_tag}"
echo " git push upstream release-${version}"
echo " git push upstream ${git_tag}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be against hard-coding the branch to push to. These are more of a suggestion, as not everyone has an upstream branch. Some keep origin as origin and others upstream or another convention.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just documenting that you should be pushing to the Linode org repo should be enough, in my opinion.

echo "Then go into GitHub and PR into master:"
echo "https://github.com/linode/linode-api-docs/compare/master...release-${git_tag}"
fi