LKE Beta Endpoints #126
LKE Beta Endpoints #126
Conversation
Add /lke/clusters/{clusterId}/pools/{poolId} collection
Add information about beta to LKE endpoint descriptions
This will help a user know what LKE refers to if used within any endpoint descriptions.
…ub.com:leslitagordita/linode-api-docs into lke-add-endpoints
Add reference to LKENodePool and LKENodePoolRequestBody to POST endpoint. Remove `node_pools` property from LKECluster and LKEClusterRequestBody
|
please add: |
openapi.yaml
Outdated
| content: | ||
| application/json: | ||
| schema: | ||
| $ref: '#/components/schemas/LKENodePoolRequestBody' |
There was a problem hiding this comment.
I think both type and count need to be required here see lines 312-318 of apinext/apinext/blueprints/beta/lke_clusters.py
|
A general note for beta - LKE is available in us-central and with Kubernetes version 1.16, these should be updated in the examples. |
openapi.yaml
Outdated
| type: object | ||
| properties: | ||
| count: | ||
| allOf: |
There was a problem hiding this comment.
I believe this needs to be required.
|
Additionally we want to add a link to the beta sign up page with the beta note. |
required should be be an array of property names required within an object schema
Copy edits, update response sample example
hzoppetti
requested review from
michaelsaah and
jnschaeffer
and removed request for
michaelsaah
openapi.yaml
Outdated
| version: | ||
| type: string | ||
| description: > | ||
| The desired Kubernetes version for this Kubernetes cluster. |
There was a problem hiding this comment.
could add, "In the format of <major>.<minor>, and the latest supported patch version will be deployed"
openapi.yaml
Outdated
| tags: | ||
| type: array | ||
| description: > | ||
| An array of tags applied to the Kubernetes cluster and _all |
There was a problem hiding this comment.
The "and all resources created by the Kubernetes cluster (such as NodeBalancers and Volumes)." part of this is not currently deployed and is still an open design question. It may become a new field. My suggestion is to remove it here.
| description: > | ||
| A Kubernetes version number available for deployment | ||
| to a Kubernetes cluster. | ||
| example: "1.16" |
There was a problem hiding this comment.
The curl example response for this one should use this string rather than show an integer 1234
Release 1.0.18
4-11-0 changelog link fix
/lke/clusters/lke/clusters/{clusterId}/lke/clusters/{clusterId}/pools/lke/clusters/{clusterId}/pools/{poolId}/lke/clusters/{clusterId}/kubeconfig/lke/versions/lke/versions/{version}Note: This work was started by @asauber and @jfrederickson in bits repo. This adds latest updates to that worki.